[ 
https://issues.apache.org/jira/browse/HADOOP-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637140#action_12637140
 ] 

Sanjay Radia commented on HADOOP-4044:
--------------------------------------

Some minor comments on FileSystem side of the patch.

- I prefer the name symlink instead of link. Unix terminology uses link for 
hard link and symlink for symbolic link. I think we should stick to it
regardless of whether or not we plan to add hard links in the future.
- Dhruba you left some of the implementation methods public, they should be 
protected.
- minor -- the method next() suggests that one follows the path to the next 
symbolic link. It does not strictly. I suggest calling it doOperation() (this 
is 
style issue and so merely a soft suggestion). 

> Create symbolic links in HDFS
> -----------------------------
>
>                 Key: HADOOP-4044
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4044
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: symLink1.patch, symLink1.patch, symLink4.patch, 
> symLink5.patch, symLink6.patch, symLink8.patch, symLink9.patch
>
>
> HDFS should support symbolic links. A symbolic link is a special type of file 
> that contains a reference to another file or directory in the form of an 
> absolute or relative path and that affects pathname resolution. Programs 
> which read or write to files named by a symbolic link will behave as if 
> operating directly on the target file. However, archiving utilities can 
> handle symbolic links specially and manipulate them directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to