[
https://issues.apache.org/jira/browse/HADOOP-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637514#action_12637514
]
Hemanth Yamijala commented on HADOOP-4053:
------------------------------------------
Some questions on the changes:
- In the implementation of jobUpdated, we are checking for instance of event
being {{JobStatusChangeEvent}}, but not for relevant event types. So, if we add
more event types later, we might need to change this implementation. I think it
is safe to check that the event types are ones we are interested in.
- In {{JobQueueManager}}, I am thinking if it's a good idea to retain the
implementation in {{jobRemoved}} just in case.
- I couldn't find a test case that tests priority changes are handled
correctly. Is this added ?
Rest of the changes look ok.
> Schedulers need to know when a job has completed
> ------------------------------------------------
>
> Key: HADOOP-4053
> URL: https://issues.apache.org/jira/browse/HADOOP-4053
> Project: Hadoop Core
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Vivek Ratan
> Assignee: Amar Kamat
> Priority: Blocker
> Attachments: HADOOP-4053-v1.patch, HADOOP-4053-v2.patch,
> HADOOP-4053-v3.1.patch, HADOOP-4053-v3.2.patch, HADOOP-4053-v4.patch
>
>
> The JobInProgressListener interface is used by the framework to notify
> Schedulers of when jobs are added, removed, or updated. Right now, there is
> no way for the Scheduler to know that a job has completed. jobRemoved() is
> called when a job is retired, which can happen many hours after a job is
> actually completed. jobUpdated() is called when a job's priority is changed.
> We need to notify a listener when a job has completed (either successfully,
> or has failed or been killed).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
