[
https://issues.apache.org/jira/browse/HADOOP-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated HADOOP-5206:
--------------------------------
Attachment: HADOOP-5206.patch
Patch fixes the two instances Konstantin mentioned. Also scanned through the
class to make sure there were no others. All unit tests pass except known-bad
HADOOP-4907.
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
{noformat}
No new unit test as is synchronization fix and not easily testable.
> All "unprotected*" methods of FSDirectory should synchronize on the root.
> -------------------------------------------------------------------------
>
> Key: HADOOP-5206
> URL: https://issues.apache.org/jira/browse/HADOOP-5206
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.20.0
> Reporter: Konstantin Shvachko
> Assignee: Jakob Homan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5206.patch
>
>
> Synchronization on {{rootDir}} is missing for two (relatively new) methods:
> - {{unprotectedSetQuota()}}
> - {{unprotectedSetTimes()}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
