[ 
https://issues.apache.org/jira/browse/HADOOP-5206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672884#action_12672884
 ] 

Hadoop QA commented on HADOOP-5206:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12400037/HADOOP-5206.patch
  against trunk revision 743513.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3836/console

This message is automatically generated.

> All "unprotected*" methods of FSDirectory should synchronize on the root.
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-5206
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5206
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Konstantin Shvachko
>            Assignee: Jakob Homan
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5206.patch
>
>
> Synchronization on {{rootDir}} is missing for two (relatively new) methods:
> - {{unprotectedSetQuota()}}
> - {{unprotectedSetTimes()}}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to