[ 
https://issues.apache.org/jira/browse/HADOOP-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678823#action_12678823
 ] 

Hadoop QA commented on HADOOP-5360:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12401147/HADOOP-5360.patch
  against trunk revision 749919.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 release audit.  The applied patch generated 805 release audit warnings 
(more than the trunk's current 797 warnings).

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/5/testReport/
Release audit warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/5/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/5/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/5/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/5/console

This message is automatically generated.

> Move from cronjob based watchdog for Chukwa Agent and System metrics to 
> daemon tools startup script
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5360
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5360
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>         Environment: Redhat EL 5.1, Java 6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Minor
>         Attachments: HADOOP-5360.patch
>
>
> Instead of waiting one minute for cron job based watchdog to check the pid 
> file and determine if the process is running.  Netops request this to be 
> changed to use deamon tools to improve the uptime of chukwa agent and system 
> metrics.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to