[
https://issues.apache.org/jira/browse/HADOOP-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694960#action_12694960
]
Sreekanth Ramakrishnan commented on HADOOP-5419:
------------------------------------------------
Looked at the patch uploaded. Following are the comments which I had while
looking at the code:
* Bump up the {{JobSubmissionProtocol}} version by one.
* Formatting change, can we change the output format to following:
{noformat}
Queue acls for user : <username>
Queue Name : qu1 Job Operations : submit administer
Queue Name : qu2 Job Operations : submit
{noformat}
* Can't just define a {{toString()}} method in {{QueueAclsInfo}} to directly
present the string in the way it has to be printed to Console?
* Why has {{getUGI()}} in {{JobClient}} made Public? Can we figure out other
methods by which we can see to that visiblity of the method is not changed to
public unless it is a pressing reason.
* Shouldn't this new method {{getQueueAclsInfo}} in {{QueueManager}} be
thread-safe? Because
[HADOOP-5396|https://issues.apache.org/jira/browse/HADOOP-5396] can refresh
queue acls while user is looking thro' ACL maps which QueueManager uses.
* Minor nit enclose if block in {{getQueueAclsInfo}} in {{QueueManager}} in
line 337.
> Provide a way for users to find out what operations they can do on which M/R
> queues
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5419
> URL: https://issues.apache.org/jira/browse/HADOOP-5419
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Hemanth Yamijala
> Assignee: rahul k singh
> Attachments: hadoop-5419.patch
>
>
> This issue is to provide an improvement on the existing M/R framework to let
> users know which queues they have access to, and for what operations. One use
> case for this would that currently there is no easy way to know if the user
> has access to submit jobs to a queue, until it fails with an access control
> exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
