[
https://issues.apache.org/jira/browse/HADOOP-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695256#action_12695256
]
Sreekanth Ramakrishnan commented on HADOOP-5419:
------------------------------------------------
Took a look at the changes, everything is fine, expect few comments:
* Why are we using a {{MiniMRCluster}} for test case? Why cant we directly use
{{QueueManager.getQueueAclsInfo(String)}} that would help us reduce run time of
the test case.
* Why cant we move the replacing of "acl-" in {{toString()}} method of
{{QueueAclsInfo}} so that in your
{{JobQueueClient.displayQueueAclsInfoForCurrentUser()}} we can just do following
{noformat}
for(QueueAclsInfo queueinfo: queueAclsInfo){
System.out.println(queueinfo);
}
{noformat}
* Also, we should be adding this to {{TestCLI}}, we should do that as a part of
a Seperate JIRA, or HADOOP-5080 if it is not commited.
* Please document the new command in hadoop commands manual
Minor nit:
* Keep line width not more than 80 characters in
{{QueueManager.getQueueAclsInfo(String)}}
> Provide a way for users to find out what operations they can do on which M/R
> queues
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5419
> URL: https://issues.apache.org/jira/browse/HADOOP-5419
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Hemanth Yamijala
> Assignee: rahul k singh
> Attachments: hadoop-5419.patch, hadoop-5419.patch, hadoop-5419.patch
>
>
> This issue is to provide an improvement on the existing M/R framework to let
> users know which queues they have access to, and for what operations. One use
> case for this would that currently there is no easy way to know if the user
> has access to submit jobs to a queue, until it fails with an access control
> exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
