Kurchi,
Great work. I've been through the complete webrev and I think it looks
good. Just a few minor comments:
- there are API changes, but only in sun private implementation
classes, so this should be fine.
- Minor indentation nit where method declaration return type
was generified. The method args on subsequent lines should be
equally indented. Example LoaderHandler.java L152:
public static Class<?> loadClass(String codebase, String name,
>>>> ClassLoader defaultLoader)
- There are opportunities to use auto boxing/unboxing
>: diff RMIGenerator.java
99c99
< version = versionOptions.get(arg);
---
> version = (versionOptions.get(arg)).intValue();
ConnectionMultiplexer.java
>: diff ConnectionMultiplexer.java ConnectionMultiplexer.java.1
133a134
< Integer idObj;
150c151,152
> info = connectionTable.get(id);
---
< idObj = new Integer(id);
< info = connectionTable.get(idObj);
158c160
> connectionTable.put(id, info);
---
< connectionTable.put(idObj, info);
.....
-Chris.
On 22/02/2012 05:50, Kurchi Hazra wrote:
Corrected the subject line.
Hi,
The following webrev removes warnings in sun.rmi.* packages. I have
neglected nearly all
deprecation warnings, since this code uses deprecated classes such as
java.rmi.server.LogStream
with no suggested replacements. I have included -Xlint:all,-deprecation
as an option instead
in the appropriate Makefiles.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146763
Webrev: http://cr.openjdk.java.net/~khazra/7146763/webrev.00/
Thanks,
Kurchi
