On 02/24/2012 08:01 PM, Kurchi Hazra wrote:
Hi Stuart,Thanks for the detailed explanation. Here is an updated webrev: http://cr.openjdk.java.net/~khazra/7146763/webrev.02/
Hi Kurchi, the field logClassConstructor should not be changed after all, it should be declared as a Constructor<? extends LogFile> so you can remove the cast to LogFile at line 542. with this change, the patch looks good to me.
- Kurchi
cheers, Rémi