Hi Kurchi,
overall the changes look good. I have a few comments:
- TCPTransport: Lines #552/553: I actually prefer the way it was as I
think it's more readable.
- RMIMasterSocketFactory: Line #244: The comment was removed, was there
a reason for this?
- HttpInputStream: Line #73: Why even have this if statement? I'd make
this a comment instead, something like if contentLengthFound, we should
probably do something in this case.
- CGIHandler: Line #288: Why even have this if statement? I'd make this
a comment instead, something like if contentLengthFound, we should
probably do something in this case.
Darryl
On 02/21/2012 09:50 PM, Kurchi Hazra wrote:
Corrected the subject line.
Hi,
The following webrev removes warnings in sun.rmi.* packages. I have
neglected nearly all
deprecation warnings, since this code uses deprecated classes such as
java.rmi.server.LogStream
with no suggested replacements. I have included
-Xlint:all,-deprecation as an option instead
in the appropriate Makefiles.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146763
Webrev: http://cr.openjdk.java.net/~khazra/7146763/webrev.00/
Thanks,
Kurchi
