On 31/05/2012 17:48, Rob McKenna wrote:
That link should be:
http://cr.openjdk.java.net/~robm/4244896/webrev.04/
-Rob
I'm happy the spec has come good too. One small suggestion is to tweak
this line:
"{@code Process} objects returned by {@link ProcessBuilder#start} and
{@link Runtime#exec} are of type that overrides this method and so
invoking this method will forcibly terminatethe process. "
to
"Invoking this method on {@code Process} objects returned by {@link
ProcessBuilder#start} and {@link Runtime#exec} will forcibly terminate
the process".
Alsoin this sentence:
"... is called, however this method may be chained to {@code waitFor()}
if needed."
may be clearer if you put "This method may be ..." as a separate sentence.
Otherwise I think it reads well.I hope to review the implementation and
test soon.
-Alan
