Hi!
> The one possible addition is to check that m1 hasn't been modified
> after the mutation of m2.
Sounds good. I have added the second test and retested against both
OpenJDK and OracleJDK builds:
[ Code Review for jdk ]
http://cr.openjdk.java.net/~dbuck/7198904/webrev.01/
Would someone please review this new version of the test case?
Cheers,
-Buck
On 11/16/12 11:45, Mike Duigou wrote:
Looks like a good test to me as well. The one possible addition is to check
that m1 hasn't been modified after the mutation of m2.
Mike
On Nov 14 2012, at 05:38 , David Buck wrote:
Hi!
This is a review request to add only the test case for the following OracleJDK
issue:
[ 7198904 : (alt-rt) TreeMap.clone is broken ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198904
The issue (root cause) is not in OpenJDK (i.e. the problem was OracleJDK
specific), but the test case is valid for both so it should go into OpenJDK so
we can prevent a similar issue from ever happening in both releases moving
forward.
webrev:
[ Code Review for jdk ]
http://cr.openjdk.java.net/~dbuck/7198904/webrev.00/
The OracleJDK fix (closed source) is ready and has already passed code review.
I intend to push both the OracleJDK fix and this test case into their
respective repositories at the same time once this review is done.
Regards,
-Buck