On 01/22/13 20:21, Joe Darcy wrote: > Hello Eric, > > In Executable, > > 283 // TODO: This may eventually need to be guarded by security > 284 // mechanisms similar to those in Field, Method, etc. > > If not done so already, please file a bug to note this item for > follow-up work.
I will do so. There was no mention of this sort of thing in the spec at the time I created Parameter.java, and I noticed its presence elsewhere. Also, I know there is a security analysis going on concerning possible vulnerabilities, but as far as I'm aware, it has not delivered a report yet. > > Extra space: > > 316 > 317 parameters = tmp; > 318 > 319 } > Fixed. > Parameter.java > > 41 * @author Eric McCorkle > > We generally don't use author tags in new code under /src. > Removed > For consistency with existing code > (http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f9c19741285), please add an > "@jls 13.1 The Form of a Binary" tag to the isSynthethic method. > Done. > The @since tags on getAnnotation, getAnnotations, getDeclaredAnnotation, > etc. are redundant with the @since on the Parameter type itself and > should be removed. > Done > Executable.c > > Please verify the "Copyright (c) 1994, 2010" range on this file is > correct and that an copyright end range of "2013" is applied as > appropriate. > The copyright range was not correct. I'd copy-pasted it and forgotten to change it. It's fixed now. > Otherwise looks fine. > > Thanks, > > -Joe > Thanks for the review, Joe. Can anyone volunteer to push this for me? I am not a committer. Eric
