On 03/27/2013 03:01 AM, Martin Buchholz wrote:
Hi Martin,
the code looks good,
I've just noticed that you declare the char array value final in appendNull
but it's not something that is usually done in the java.lang codebase.
Rémi
Oops: I forgot to include core-libs-dev
Forwarded conversation
Subject: RFR: Optimize StringBuilder.append(null)
------------------------
From: *Martin Buchholz* <[email protected]>
Date: Tue, Mar 26, 2013 at 1:54 PM
To: Xueming Shen <[email protected]>, Masayoshi Okutsu <
[email protected]>, Ulf Zibis <[email protected]>, Mike Duigou <
[email protected]>
Hi! It's me again, fiddlling with StringBuilder.
One of our users noticed that a lot of CPU time was being spent in
StringBuilder.append(null).
We can apply the previously proven optimization that improves it by a
factor of 2 on microbenchmarks.
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/StringBuilder.appendNull/
----------
From: *Mike Duigou* <[email protected]>
Date: Tue, Mar 26, 2013 at 1:58 PM
To: Martin Buchholz <[email protected]>
Cc: Xueming Shen <[email protected]>, Masayoshi Okutsu <
[email protected]>, Ulf Zibis <[email protected]>
This looks fine to me. Do you need a bug number?
Mike
----------
From: *Martin Buchholz* <[email protected]>
Date: Tue, Mar 26, 2013 at 2:02 PM
To: Mike Duigou <[email protected]>
Cc: Xueming Shen <[email protected]>, Masayoshi Okutsu <
[email protected]>, Ulf Zibis <[email protected]>
On Tue, Mar 26, 2013 at 1:58 PM, Mike Duigou <[email protected]> wrote:
This looks fine to me. Do you need a bug number?
Yes, I do (thanks!)
----------
From: *Mike Duigou* <[email protected]>
Date: Tue, Mar 26, 2013 at 2:12 PM
To: Martin Buchholz <[email protected]>
Cc: Xueming Shen <[email protected]>, Masayoshi Okutsu <
[email protected]>, Ulf Zibis <[email protected]>, Jim Gish <
[email protected]>
I have created:
JDK-8010849: (str) Optimize StringBuilder.append(null)
(yes we know that requiring an Oracle engineer create the bug is a problem.
SOON!)
Mike
----------
From: *Mike Duigou* <[email protected]>
Date: Tue, Mar 26, 2013 at 6:57 PM
To: Martin Buchholz <[email protected]>
Hi Martin;
I hadn't originally noticed but can you make sure to send a RFR through
core-libs-dev for this issue?
Mike
