I am happy with the latest webrev - ship it! Thanks, John!
On Wed, Apr 10, 2013 at 10:54 AM, John Zavgren <john.zavg...@oracle.com>wrote: > Greetings: > > There is a new webrev image available for your inspection that fixes all > identified bugs: > http://cr.openjdk.java.net/~jzavgren/8008118/webrev.07/ > > Your comments are welcome. > > Thanks! > John > > > On 03/29/2013 09:59 AM, chris...@zoulas.com wrote: > > On Mar 28, 8:42pm, marti...@google.com (Martin Buchholz) wrote: > -- Subject: Re: RFR-8008118 > > | Latest webrev does it this way: > | > | for (i = 0; i < count; i++) { > | char *q = p + strcspn(p, ":"); > | pathv[i] = (p == q) ? "." : p; > | *q = '\0'; > | p = q + 1; > | } > > I prefer to have loops where the sentinel is the actual condition instead > of something computed independently, but that's fine too. > > christos > > PS: Can we please add strsep(3) to solaris at some point? Everyone else > relevant seems to have it. > > > > -- > John Zavgrenjohn.zavgren@oracle.com603-821-0904 > US-Burlington-MA > >
