On Apr 10, 1:54pm, john.zavg...@oracle.com (John Zavgren) wrote: -- Subject: Re: RFR-8008118
| Your comments are welcome. 1. We did we switch from NEW() to xmalloc()? Why is the xmalloc cast needed? 2. I would not declare pathv "const char **", but "char **", and then cast the return if needed. This will make life easier in the future if we decide to turn on warnings about const-castaways. Otherwise LGTM. christos