- License on test is the wrong one. Tests don't have classpath exemption.

- The initial block comment with @test doesn't have the normal leading * on 
each line.

- The commented out part mentioning testWrite should just be removed along with 
unreferenced code.

Looks otherwise fine to me.

Mike

On Apr 10 2013, at 21:24 , Robert Field wrote:

> Currently blocking lambda library pushes.  Internal class reader used by rmic 
> does not support new constant pool constant types:
> 
> CONSTANT_METHODHANDLE         = 15;
> 
> CONSTANT_METHODTYPE           = 16;
> 
> CONSTANT_INVOKEDYNAMIC        = 18;
> 
> 
> Please review the fix for CR:
> 
>     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011805
> 
> Webrev:
> 
>     http://cr.openjdk.java.net/~rfield/8011805/

Reply via email to