Re: RFR 8011805: Update sun.tools.java class file reading/writing support to include the new constant pool entries (including invokedynamic)

[Alan Bateman]

On 11/04/2013 05:24, Robert Field wrote:
Currently blocking lambda library pushes.  Internal class reader used by
rmic does not support new constant pool constant types:
   CONSTANT_METHODHANDLE         = 15;

   CONSTANT_METHODTYPE           = 16;

   CONSTANT_INVOKEDYNAMIC        = 18;


Please review the fix for CR:

       http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011805

Webrev:

       http://cr.openjdk.java.net/~rfield/8011805/

The changes looks fine but I agree with Mike's comments on the test.

One other comment on the test is that it looks like ClassConstantChecker 
opens the class file but never closes it. Ideally all tests would 
clean-up/close resources before they complete as otherwise it causes 
problems in some execution modes.

-Alan.