On 25/04/2013 15:41, Alexey Utkin wrote:
Alan,
Thanks for your comments.
I did the changes in code.
Please, read my answers below.
Here is fixed version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.02/
The implementation changes look good now.
:
One thing I see is that it doesn't read from the child's output/error
streams so if there is a problem then it will be hard to diagnose
from the logs.
The diagnostic includes logging of the command line in problem. It
should not be a problem to localize issue.
We'll see, sometimes it is hard to diagnose issues when you can see the
output from the child. What you have is fine and we can easily change
the test if we run into issues.
-Alan
