On Wed, May 8, 2013 at 5:30 PM, Mike Duigou <mike.dui...@oracle.com> wrote:
> > Direct-X-Buffer.java:: > > - +#if[rw] public boolean isDirect() : Why would this be conditionalized > with rw? > > Welcome to the -X- files. Since you have conditional preprocessing and inheritance happening at the same time, all readonly methods should be within #if[rw] > > Heap-X-Buffer.java:: > > - protected -> private int ix(int i) : Is Alan OK with this change. I've > mostly avoided these templates. :-) > > Make things as private as you can. Possible now that subclass no longer needs to access these fields. > > X-Buffer.java.template:: > > - toString() could use the JavaLangAccess.newUnsafeString() constructor! > > Right! I've been semi-waiting for that! > - I prefer your formatting of "return bigEndian ?". > > > test/.../GetChars:: > > - Great to see you've already adopted using TestNG for JTReg tests! > > It's my first TestNG test! > - ArraysCharSequence.hashCode() could have been Arrays.hashcode(chars) or > not implemented at all. > > I removed it. More later.
