+1 for this patch. (Thanks, Petr!) I have tried it in the latest jdk8 (b91) and it fixes both of the SWT+OpenJDK7&8 bugs that I submitted in the Eclipse bugzilla. Would be great if this could be accepted at least for jdk8 (if not jdk7u too).
Cheers, Nick On Tue, May 21, 2013 at 1:07 PM, Petr Pchelko <petr.pche...@oracle.com>wrote: > Added macosx-port-dev > > On May 21, 2013, at 10:57 AM, David Holmes wrote: > > > Adding core-libs as this is actually a launcher change. > > > > David > > > > On 21/05/2013 4:36 PM, Petr Pchelko wrote: > >> Hello, AWT Team. > >> > >> Please review the fix for the issue: > >> http://bugs.sun.com/view_bug.do?bug_id=8009911 > >> The webrev is available at: > >> http://cr.openjdk.java.net/~pchelko/8009911/webrev.00/ > >> > >> The problem: > >> When launching java with -XstatrOnFirstThread we were using > dispatch_sync to start a Java main on the main thread. This blocked the > main dispatch queue, so all the subsequent calls to GCD were never invoked. > GCD is used a bit in our code, but it is used inside Cocoa, for example for > fullscreen. > >> > >> The solution: > >> We now launch Java main using a performSelectorOnMaintThread, so we do > not block GCD. > >> > >> Notes: > >> 1. This also fixes the following SWT bug: > https://bugs.eclipse.org/bugs/show_bug.cgi?id=388886 > >> 2. Although I have added OBJC syntax into java_md_macosx.c file, I did > not rename it to .m, because: > >> a. It is hard to update an old build system to compile with the > new file name. > >> b. It is already compiled with -x objective-c, so I will compile > >> c. We would have lost all the hg history for this file. > >> > >> With best regards. Petr. > >> > >
