On 6/10/13 9:04 PM, Mike Duigou wrote:
StubDelegateImpl.java::
- Could just call Objects.hashCode(ior);
RepIdDelegator::
- Could also call Objects.hashCode(delegate) as it extends nothing the
super.equals(delegate) is calling Object.equals
Depends on whether you intend to backport the patch to jdk7.
I suspect that CORBA is like JAXP - in that it needs to be compiled with the
bootstrap JDK (if I remember well it's compiled before JAXP).
Otherwise - I'd agree with mike :-)
-- daniel
Mike
On Jun 10 2013, at 04:11 , Alan Bateman wrote:
The warnings from the build of the corba repository on missing hashCode methods
have been annoying me for some time. I was hoping they would annoy others too
but looks like I blinked first :-)
Here's the webrev with the changes that I'd like to push to fix the issues:
http://cr.openjdk.java.net/~alanb/8016218/webrev/
Note that there are 3 real issues but they are obvious. I'm running the CORBA
tests to make sure that it doesn't break anything. Note that the bulk of the
warnings were coming from ParserTable but they turn out not to be interesting
because they are only used in the testing framework.
-Alan.
