Hi Joel,
The spec changes look good in their current form.
I'd prefer to see the test re-structure to have class code duplication,
but it is acceptable in its present form.
Cheers,
-Joe
On 9/4/2013 6:25 AM, Joel Borggren-Franck wrote:
Hi all,
Thanks for the comments. New webrev here:
http://cr.openjdk.java.net/~jfranck/5047859/webrev.03/
I have also created a specdiff to make it easier to visualize the doc
change:
http://cr.openjdk.java.net/~jfranck/5047859/specdiff/overview-summary.html
I made some bigger changes this time to unify the doc of all four
get{Declared}Field{s} methods. I also try to be consistent with the
proposed doc change for getMethods and friends that I will post later
today.
General outline of the docs is roughly:
<!-- Basic result -->
<!-- Interesting results -->
<!-- Empty results -->
<!-- Order of results -->
I also updated the test to cover all four cases.
cheers
/Joel
On 2013-08-26, Joel Borggren-Franck wrote:
Hi,
Please review doc fix and test for
http://bugs.sun.com/view_bug.do?bug_id=5047859
http://cr.openjdk.java.net/~jfranck/5047859/webrev.00/
This is a spec change to update the spec to match the long-standing
implementation.
There is also a clarification of getFields() javadoc without changing the
spec.
cheers
/Joel
