On 10/17/2013 02:01 PM, Stephen Colebourne wrote:
I'm happy with the contents of this webrev.
As pointed out previously, it doesn't address the specific issue in 8025971
Stephen
On 17 October 2013 21:53, Xueming Shen<xueming.s...@oracle.com> wrote:
Webrev has been updated accordingly based on your suggestion.
http://cr.openjdk.java.net/~sherman/8025971_8026197/webrev
thanks!
-Sherman
On 10/16/2013 01:09 AM, Stephen Colebourne wrote:
On 15 October 2013 20:35, Xueming Shen<xueming.s...@oracle.com> wrote:
Please help codereview the changes for
8025971: Remove Time-Zone IDs HST/EST/MST
The method ZoneId.systemDefault() now does not match its specification:
/**
* Gets the system default time-zone.
*<p>
* This queries {@link TimeZone#getDefault()} to find the default
time-zone
* and converts it to a {@code ZoneId}. If the system default
time-zone is changed,
* then the result of this method will also change.
*
* @return the zone ID, not null
* @throws DateTimeException if the converted zone ID has an invalid
format
* @throws ZoneRulesException if the converted zone region ID cannot be
found
*/
public static ZoneId systemDefault() {
return ZoneId.of(TimeZone.getDefault().getID(), SHORT_IDS);
}
This needs to be changed to:
public static ZoneId systemDefault() {
return TimeZone.getDefault().toZoneId();
}
This fix is for a different issue - not the one described in the
8025971 bug report. I recommend opening a new issue. If you're not
going to fix 8025971 (which I think you should) then that needs to be
documented.
Stephen
I will file a separate issue to address the issue. I would assume you are
recommending
to complete remove these three short ids from jvm?
-sherman
