On 23/10/2013 15:32, roger riggs wrote:
:

The signature of the readObject methods usually has the return type Object even though in this case it should never be used. And a method comment would be nice
saying why it always throws an exception.
I checked Serializable and it defines readObject's return type as void. We could add a javadoc comment if needed but the @throws should be sufficient for testing.


I might have been tempted to conserve on classes and code duplication to
share a serialization proxy between the classes and maybe even shorten the name. But it is hard to argue with the simplicity and directness of this design.
I don't have a strong opinion on this, it could be something really like short (if Doug is inclined).

-Alan.

Reply via email to