Hi
   an updated webrev as per suggested changes
http://cr.openjdk.java.net/~msheppar/8036603/webrev.01/


regards
Mark

On 07/03/2014 22:21, Mark Sheppard wrote:
Thanks Alan and Mandy for the feedback

I make the amendments as you both suggest

regards
Mark

On 07/03/2014 21:34, Alan Bateman wrote:
On 07/03/2014 21:24, Mark Sheppard wrote:

Hi,
   Please oblige and review the changes
http://cr.openjdk.java.net/~msheppar/8036603/webrev/

which address the issues raised in
https://bugs.openjdk.java.net/browse/JDK-8036603

summary
JNU_ClassString extracted as parameter to GetMethodID and NewObject calls
and NUL_CHECKed
Is it necessary to call JNU_ClassString twice? (just wondering if L65-66 can be removed). One suggestion for class_for_method is to rename it to str_class as it might be a bit clearer.

-Alan.


Reply via email to