Re: RFR: JDK-8036603 - Check jdk/src/windows/native/java/lang/ProcessEnvironment_md.c for JNI pending exceptions

[Mark Sheppard]

Hi Alan,
   so L61 should be

if ((bytes = (*env)->NewByteArray(env, i)) == NULL) {
    FreeEnvironmentStringsA(blockA);
    return NULL;
}

regards
Mark


On 12/03/2014 17:24, Alan Bateman wrote:

On 12/03/2014 17:18, Mark Sheppard wrote:

Hi
   an updated webrev as per suggested changes
http://cr.openjdk.java.net/~msheppar/8036603/webrev.01/

This looks good. One other thing in this code (pre-dates your patch but your patch makes it a bit more obvious) is that if NewByteArray fails then we don't call FreeEnvironmentStringsA to free the environment.

-Alan