Thanks, Alan.
On Mon, Aug 25, 2014 at 1:28 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > On 25/08/2014 18:37, Martin Buchholz wrote: > > Hi friends of ByteArrayOutputStream, > > I'm trying to clean up an apparent oversight when I tried to fix huge > array resizing back in > 6933217: Huge arrays handled poorly in core libraries > > https://bugs.openjdk.java.net/browse/JDK-8055949 > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/ByteArrayOutputStream-MAX_ARRAY_SIZE/ > > The 2x capacity gap was noticed by real users! > > The change to BAOS looks okay, I don't recall why it wasn't updated with > the previous changes. > > I'm not sure about adding a test with @ignore though, maybe the @test > should just be dropped to avoid the temptation to "fix" the test before > there is support for selecting tests based on the resources available. > > jtreg tests are run by default with -ignore:quiet and there is precedent for other tests with such @ignore statements, and I actually used jtreg -ignore:run to really test this. What I would really like someday is to be able to run expensive tests (like this one) only if a user expressly requested them. Anyways, I'm intending to submit as is unless you feel strongly.
