> On 13 jan 2015, at 13:26, David Holmes <david.hol...@oracle.com> wrote: > > Hi Daniel, > > On 13/01/2015 7:53 PM, Daniel Fuchs wrote: >> On 13/01/15 04:52, David Holmes wrote: >>>> Here is the new webrev with Stephen & your feedback included >>>> http://cr.openjdk.java.net/~dfuchs/webrev_8068730/webrev.01/ >>>> >>>> (windows_time_stamp not renamed yet) >>> >>> I checked the updated webrev.02 and everything looks good on the hotspot >>> side. >>> >>> What are your plans for pushing this? >> >> Thanks David, >> >> My understanding is that I'll need to push that through hs-rt - since >> it has changes for hotspot. I believe I'll need two reviewers - is that >> right? Roger Riggs has also reviewed the changes on core-libs-dev, so >> is this good to go, or do both reviewers need to be members of the hsx >> project? > > hsx project is defunct, so technically we're all just jdk9 reviewers, but we > still like two reviews from hotspot team members.
I’ve looked at the hotspot changes: Looks good! Thanks, /Staffan > >> Also - I am not sure whether I need a sponsor (I have never pushed >> anything to hs-rt - I usually push in jdk9-dev) or whether I am >> allowed to push this myself (I'll use jprt in that case). > > If you are a jdk9 committer then you can push yourself via jprt - full forest > submission from top-level: "jprt submit -forest -testset hotspot" > > David > >> best regards, >> >> -- daniel >> >>> >>> David >>> -----
