Thank you, Joe. I will sort the tests as your suggestion, and have 3 questions to confirm with you: 1. Should I also sort the gap tests? 2. Should I put astro suite at side of auctionportal? 3. If a package has very few test, e.g. I may put XMLEventFactoryTest and something else in javax.xml.stream.ptest, is it ok? (I would rename XMLEventFactoryTest as its small coverage)
Best Regards Frank -----Original Message----- From: huizhe wang [mailto:huizhe.w...@oracle.com] Sent: Wednesday, January 28, 2015 10:27 AM To: Frank Yuan Cc: 'Lance Andersen'; 'Core-Libs-Dev'; 'jibing chen'; 'Gustavo Galimberti'; sandeep.konch...@oracle.com; 'Alexandre (Shura) Iline' Subject: Re: Review request for JDK-8051710: Convert JAXP function tests: javax.xml.jaxp14.* to jtreg (testng) tests Hi Frank, Nice refactoring the original tests, esp. the TransformerTest! jaxp14 is legacy in the jaxp standalone world. While we are at this, you may want to move these tests to their relevant packages since in the JDK world, jaxp14 is no longer relevant (jaxp 1.4 was integrated into JDK 6). As you've already split FactoryTest into various Factory tests, you may find them a bit thin in terms of test coverage now that they are named *FactoryTest since they cover just one of the two newInstance methods. I would think it makes sense to move them into / combine with the Factory tests of their own packages. Thanks, Joe On 1/27/2015 1:09 AM, Frank Yuan wrote: > Hi, Joe, Lance and All > > We are working on moving internal jaxp functional tests to open jdk repo. > This is the jaxp14 suite. Would you please review these test? Any comment > will be appreciated. > > bug: https://bugs.openjdk.java.net/browse/JDK-8051710 > webrev: http://cr.openjdk.java.net/~fyuan/8051710/webrev.00/ > > > Thanks, > > Frank >
