Hello Roger,
Build change looks fine to me.
/Erik
On 2015-06-15 23:58, Roger Riggs wrote:
Please review code for Windows 10 that sets the System properties for
os.name and os.version
from the version of kernel32.dll. The update uses the same technique
used by Hotspot
in src/os/windows/vm/os_windows.cpp.
The Windows link of CoreLibraries.gmk includes version.lib/dll.
The behavior of GetVersionEx has changed so it reports whatever
version the application
asserts it is compatible with instead of the current version of Windows.
See:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms724451%28v=vs.85%29.aspx
The same change is desirable for 8u60.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-win-ver-8066504/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8066504
Thanks, Roger
