On 29.6.2015 12:09, Alan Bateman wrote:
On 29/06/2015 10:10, Jan Lahoda wrote:
Thanks for the comment - done that. Updated webrev:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.03/full/
Delta against the previous iteration:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.03/delta/
How does this look? Feedback is appreciated.
Nearly there :-)
I don't think initIDs needs to return a jboolean because it throws an
exception when it fails.
I did not realize that - updated webrev:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.04/full/
Delta against previous iteration:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.04/delta/
Feedback is appreciated.
Thanks,
Jan
Also is there any reason to do this each time that a WindowsTerminal is
created. A static initializer would be more normal here.
-Alan.
