> On 9 Nov 2015, at 12:20, Alan Bateman <alan.bate...@oracle.com> wrote:
> 
> 
> 
> On 05/11/2015 21:56, Roger Riggs wrote:
>> Please review the new ProcessBuilder.startPipeline API, implementation, and 
>> tests.
>> 
>> :
>> 
>> javadoc of ProcessBuilder:  only startPipeline is new:
>>   http://cr.openjdk.java.net/~rriggs/pipedoc/
>> 
> I skimmed over the javadoc and it looks quite good.
> 
> The method name seems okay, I initially assumed it would be something like 
> startProcesses but that doesn't convey how they are arranged.
> 
> Using varargs seem reasonable for the examples like you have in the javadoc 
> but there may be other usages where this might be annoying.

Good point. In light of the imminent (getting Stuart stressed here :-) ) 
arrival of the convenience collection factories it may be better to accept a 
List<ProcesssBuilder>, especially so since this is only really useful for two 
or more process builders.

Paul.


Reply via email to