I’m not an official reviewer so here are my unofficial comments: 1. I see no obvious flaws 2. The name MultiVersion should be changed to MultiRelease to correspond with the name change in the JEP. 3. While for this test it’s okay to have versions 7, 8, and 9, in practice we won’t process version 7 or 8. Version numbers correspond to platform release numbers and will start at 9 since it’s the first release that can process MultiRelease jars.
> On Nov 16, 2015, at 2:17 PM, Kumar Srinivasan <kumar.x.sriniva...@oracle.com> > wrote: > > > John, Steve, > > I have updated the webrev which fixes the version numbers > and removes the duplicate manifest's in the jar-files. > > Full webrev: > http://cr.openjdk.java.net/~ksrini/8066272/webrev.1/ > > Incremental webrev: > http://cr.openjdk.java.net/~ksrini/8066272/webrev.1/webrev.delta/index.html > > Thanks > Kumar > > >> Hi John, Steve, >> >> Please review a fix for bug: >> https://bugs.openjdk.java.net/browse/JDK-8066272 >> >> The webrev: >> http://cr.openjdk.java.net/~ksrini/8066272/webrev.0/ >> >> To support Multi versioned jar files all versioned class files >> in the META-INF directory will be excluded from the global >> constant pool, instead these will be regarded as resources >> and stored in the resource specific bands. >> >> Thanks >> Kumar >> >
