On 12/16/2015 1:24 AM, Mikael Gerdin wrote:
On 2015-12-16 09:24, Mikael Gerdin wrote:
Hi Kumar,
On 2015-12-15 16:54, Kumar Srinivasan wrote:
Hello,
Please review fix for: JDK-8115868
The webrev is here:
http://cr.openjdk.java.net/~ksrini/8115868/webrev.0/
Since I don't feel qualified to comment on the actual code changes I
don't consider this a code review but I looked at the diffs and they
make sense to me.
I have however tested this fix and verified that it resolves the issues
in the launcher.
And as for the changes required for the VM, would it be appropriate to
clone 8115868 and move it to hotspot/runtime instead of pushing the VM
fix under the same bug number?
Right, since this issue exists in HotSpot you should file a bug on Runtime,
linking this and the JDK bug, this issue will likely exist elsewhere in
the JDK
code base as well.
Thanks
Kumar
/Mikael
/Mikael
The background:
The launcher uses stat(2) to check for the existence of a file,
unfortunately
on 32-bit system with large file systems causes the inode storage to
overflow
causing the syscall to return EOVERFLOW.
Solution:
* stat(2) replaced with access(3), in most cases.
* jbs is marked noreg-hard hard to replicate the problem
Thanks
Kumar
