On 12/16/2015 11:01 AM, Martin Buchholz wrote:
On Tue, Dec 15, 2015 at 2:12 PM, Bernd Eckenfels <e...@zusammenkunft.net> wrote:
Hello,
I always like it when access() is used instead of stat() magic.
I noticed that the new ProgramExists in java_md_common.c does not
anymore reject directories (which are typically executable). Not sure
it this matters or is intentional, it is a change in semantic.
Right. This is a small loss of robustness. Changing stat into access
here isn't really right because not stat has a superset of
functionality, and (like I keep saying) all the stat calls in the JDK
are potentially broken and need fixing.
I agree this is a very small corner case, the caller (there is one call
and will always
test for the existence of a file). So I am going to go with this, unless
I hear objections.
Kumar
