looks fine On Mar 23, 2016, at 8:39 AM, Aleksej Efimov <[email protected]> wrote:
> David, > > Thanks for approval. > > Adding corelibs-dev for getting code review. Can someone, please, take a look > at the partially backported changes [1]? > > Best Regards, > Aleksej > > [1] http://cr.openjdk.java.net/~aefimov/8145039/8/00 > > On 03/23/2016 02:16 PM, David Buck wrote: >> approved for push to jdk8u-dev pending successful code review >> >> I understand that the code review may seem over-cautious, but as you are >> only back porting a subset of the original change set, a (hopefully trivial) >> review is still needed. >> >> Cheers, >> -Buck >> >>> On Mar 23, 2016, at 09:12, Aleksej Efimov <[email protected]> wrote: >>> >>> Hi, >>> >>> Please, approve backport of xjc tool fix [1] to JDK8u-dev. >>> The source fix for this bug was delivered to JDK9 as part of sync process >>> with upstream JAXWS project [2]. >>> The change that fixed reported issue was partially, but cleanly backported >>> to JDK8 CTypeRef class. Original JDK9 changes to this class can be viewed >>> at this location [3]. >>> Test for this issue was backported cleanly. JCK and JTREG tests (including >>> the backported one) were executed over the modified JDK8 without failures. >>> >>> Best Regards, >>> Aleksej >>> >>> JDK8 webrev: >>> http://cr.openjdk.java.net/~aefimov/8145039/8/00 >>> >>> JDK9 changeset: >>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/de1f0e168eeb >>> >>> JDK9 Review thread: >>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039553.html >>> >>> JAXWS sync review thread: >>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-February/039086.html >>> >>> [1] https://bugs.openjdk.java.net/browse/JDK-8145039 >>> [2] https://bugs.openjdk.java.net/browse/JDK-8150174 >>> [3] http://hg.openjdk.java.net/jdk9/jdk9/jaxws/rev/ebff1bd3627a#l34.1 >>> > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected]
