On 25/03/16 15:57, Mandy Chung wrote:
Here is the new webrev: > >http://cr.openjdk.java.net/~dfuchs/webrev_8150840/webrev.03/index.html > >Only changes are in SimpleConsoleLogger.Formatting::getSimpleFormat.Looks okay. Minor nit: why not using String::equals? No need to have a new webrev.
Oh - just a matter of taste I guess. Objects.equals will always work :-) It's not like this code is performance sensitive: it will be called only once. Thanks Mandy! -- daniel