Hi, Mandy. Thanks for taking the time to Review.
>> http://cr.openjdk.java.net/~iris/verona/8144062/webrev.1/ > The change looks fine. Minor comments: > > 1178 * @throws IllegalArgumentException > 1179 * If the given string cannot be interpreted as a valid > 1180 * version > 1185 * @throws NumberFormatException > 1186 * If an element of the version number or the build > number > 1187 * cannot be represented as an {@link Integer} > > It’s okay to specify @throws NumberFormatException while @throws IAE (merging > the description) should be adequate (the implementation stays the same). > Something you can consider in the future. Sounds good as a future update. > 1189 * @return This version > It seems clearer to say "@return the Version of the given string” (this is a > static method and no “This version”) Nice catch. Updated: 1189c1189 < * @return This version --- > * @return The Version of the given string Thank you so much for volunteering to Sponsor this change for me. I'll send you the changesets as soon as I've finished testing my sync with jdk9/dev. Regards, Iris
