Re: RFR (JAXP): 8162598 XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace

[Joe Wang]

On 7/31/16, 2:25 PM, Langer, Christoph wrote:

Thanks, Joe.

I added some documentation to checkNodeNS8162598 and pushed: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/e66cdc2de6b0

Would you agree to downport this to jdk8?

Certainly. That's probably what the customer really needed.

Best,
Joe

Best regards

Christoph

*From:*Joe Wang [mailto:huizhe.w...@oracle.com]
*Sent:* Freitag, 29. Juli 2016 22:34
*To:* Langer, Christoph <christoph.lan...@sap.com>

*Cc:* Daniel Fuchs <daniel.fu...@oracle.com>; core-libs-dev@openjdk.java.net *Subject:* Re: RFR (JAXP): 8162598 XSLTC transformer swallows empty namespace declaration which is needed to undeclare default namespace

Hi Christoph,

All tests passed. Please add a note to the test on what's expected, or some javadoc to the method checkNodeNS8162598.

Best,
Joe

On 7/29/16, 7:55 AM, Langer, Christoph wrote:

    Hi Joe,

    here is the webrev after merging:
    http://cr.openjdk.java.net/~clanger/webrevs/8162598.2/
    <http://cr.openjdk.java.net/%7Eclanger/webrevs/8162598.2/>

    Let me know when you have done your tests -- then I'll push it.

    @Daniel: Thanks for your help regarding Stack<?>. You were right,
    I could remove that "<?>".

    Thanks & Best regards

    Christoph

    *From:*huizhe wang [mailto:huizhe.w...@oracle.com]
    *Sent:* Freitag, 29. Juli 2016 08:04
    *To:* Langer, Christoph <christoph.lan...@sap.com>
    <mailto:christoph.lan...@sap.com>; Daniel Fuchs
    <daniel.fu...@oracle.com> <mailto:daniel.fu...@oracle.com>
    *Cc:* core-libs-dev@openjdk.java.net
    <mailto:core-libs-dev@openjdk.java.net>
    *Subject:* Re: RFR (JAXP): 8162598 XSLTC transformer swallows
    empty namespace declaration which is needed to undeclare default
    namespace

    Hi Christoph,

    On 7/28/2016 6:10 AM, Langer, Christoph wrote:

        Hi,

        please review my change for the XSLT namespace issue.

        Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8162598.1/
        <http://cr.openjdk.java.net/%7Eclanger/webrevs/8162598.1/>

        Bug: https://bugs.openjdk.java.net/browse/JDK-8162598

        The issue has already been discussed in this thread:
        
http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-July/042525.html

        Apart from the real fix in LiteralElement.java, method
        translate(), I've done some further cleanups in a few places.
        @Joe: The cleanups collide with some places of your proposed
        change for https://bugs.openjdk.java.net/browse/JDK-8158084
        where we'd like to do the same things. So we'll have to
        synchronize on pushing.


    My patch has just pushed. Could you merge the changes and
    re-generate webrev?  The change looks to be sensitive. I'll build
    and run all other tests for you.

    Best,
    Joe



        I've also enhanced the test case "TransformerTest" and added a
        method which does a regression test for the bug reported.

        Thanks in advance for reviewing.

        Best regards

        Christoph