Hi, I've been a little busy with JavaOne but now I've finally pushed this change.
Thanks to everybody, Volker On Thu, Sep 15, 2016 at 8:08 AM, Hiroshi H Horii <ho...@jp.ibm.com> wrote: > Hi Volker, and Sean, > > Thank you for your comments and suggestion. > > I and Gustavo created a webrev that includes Bits and ByteArrayAccess. > > http://cr.openjdk.java.net/~gromero/8165231/02/ > > I believe there is no other similar methods in jdk. > > Regards, > Hiroshi > ----------------------- > Hiroshi Horii, Ph.D. > IBM Research - Tokyo > > > > > From: Sean Coffey <sean.cof...@oracle.com> > To: Volker Simonis <volker.simo...@gmail.com> > Cc: "jdk8u-...@openjdk.java.net" <jdk8u-...@openjdk.java.net>, Java > Core Libs <core-libs-dev@openjdk.java.net>, Hiroshi H Horii/Japan/IBM@IBMJP, > "ppc-aix-port-...@openjdk.java.net" <ppc-aix-port-...@openjdk.java.net>, > Gustavo Bueno Romero <grom...@br.ibm.com>, "Doerr, Martin" > <martin.do...@sap.com> > Date: 09/13/2016 21:46 > Subject: Re: [8u] RFR(XXS): 8165231: java.nio.Bits.unaligned() > doesn't return true on ppc > ________________________________ > > > > Sounds good Volker. Good catch. > > regards, > Sean. > > On 13/09/2016 13:09, Volker Simonis wrote: >> Hi Sean, >> >> thanks a lot for the fast response. I've updated the bug entry as >> requested and will push the change - maybe with the following >> potential improvement: >> >> @Hiroshi: also maybe not that performance relevant, I think we should >> we also fix sun/security/provider/ByteArrayAccess.java which contains >> the same construct: >> >> // Return whether this platform supports full speed int/long memory >> access >> // at unaligned addresses. >> // This code was copied from java.nio.Bits because there is no >> equivalent >> // public API. >> private static boolean unaligned() { >> String arch = java.security.AccessController.doPrivileged >> (new sun.security.action.GetPropertyAction("os.arch", "")); >> return arch.equals("i386") || arch.equals("x86") || >> arch.equals("amd64") >> || arch.equals("x86_64"); >> } >> >> Regards, >> Volker > > > >
