Very nice, it will greatly help gradle, maven, etc. in com/sun/tools/javac/main/Main.java, the other constructor should delegate its initialization to the constructor you just add, public Main(String name, PrintWriter out) { this(name, out, out); }
I wonder if findFirst() in ToolProvider should not take a ClassLoader as parameter instead of being restricted to the system classloader. regards, Rémi ----- Mail original ----- > De: "Jonathan Gibbons" <jonathan.gibb...@oracle.com> > À: "OpenJDK Dev list" <core-libs-dev@openjdk.java.net> > Cc: compiler-...@openjdk.java.net > Envoyé: Mercredi 5 Octobre 2016 01:39:47 > Objet: RFR: 8159855 > Core-libs folk, > > Please review the following change to add a new service provider class > java.util.spi.ToolProvider > > which can be used provide simple "command-line" access to select JDK > tools, without starting a new JVM. > > The following tools are updated to provide access through the new SPI: > javac, javadoc, javap, jdeps > > It is expected that additional tools will also be updated to provide access, > but that will be done separately. > > Compiler-dev folk may wish to review the changes to the langtools > repository. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8159855 > Webrev: http://cr.openjdk.java.net/~jjg/8159855/webrev.03/ > API: > http://cr.openjdk.java.net/~jjg/8159855/api.02/java/util/spi/ToolProvider.html > > -- Jon