On 05/10/2016 05:19, Mandy Chung wrote:
:
ToolProvider::findFirst(String name) can find tool providers on classpath. I
think it needs to wrap the for-loop (specifically iterating on providers) with
doPrivileged due to the stack-based permission check.
Yes, that will be needed, otherwise the caller will need permission to
get the system class loader and whatever other permissions are needed to
locate and and load the tools.
The rest looks okay to me. Personally I would space out the javadoc tags
more, and indent the second/third lines more than one space but that is
just minor stuff.
-Alan
