> On Oct 10, 2016, at 11:03 PM, Peter Levart <peter.lev...@gmail.com> wrote: > > Hi Brent, > > > On 10/11/2016 12:44 AM, Brent Christian wrote: >> On 10/10/16 2:30 PM, Mandy Chung wrote: >>> >>> The patch looks fine. It would be good to add @see >>> #registerAsParallelCapable in this new method. Also the first >>> “parallel capable” occurrance in the class spec and the >>> registerAsParallelCapable method spec to @linkplain >>> #isParallelCapable. >> >> Thanks for having a look, and for the suggestions. I also added an @see >> #isParallelCapable in registerAsParallelCapable(). >> >> Webrev updated in place: >> http://cr.openjdk.java.net/~bchristi/8165793/webrev.00/ >> >> -Brent > > It would be marginally more efficient to check for parallelLockMap != null > instead of looking up the CL implementation class in the WeakHashMap within a > synchronized block, but I guess the performance of this method is not very > important, is it?
parallelLockMap != null is another way to check that. Sinc this method isn’t performance critical, calling ParallelLoaders::isRegistered is easier to understand. Mandy
