Hi Frank, Looks good to me. Thanks for the advice Jon!
best regards, -- daniel On 24/11/16 02:29, Frank Yuan wrote:
Hi Jon Thank you for your advice! Please check the update http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/ , which contains jcommander.jar and removes the extra blank lines following Christoph’s suggestion. Frank *From:*Jonathan Gibbons [mailto:jonathan.gibb...@oracle.com] *Sent:* Thursday, November 24, 2016 4:26 AM *Subject:* Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars Frank, More recent builds of testng.jar, such as the builds available on Maven, have separated out the jcommander component so that two jar files are required: testng.jar and jcommander.jar. You should consider taking jcommander.jar into account. This will be more important/noticeable to folk outside Oracle who build their own copy of jtreg to use. -- Jon On 11/22/2016 08:41 PM, Frank Yuan wrote: Hi All Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/ <http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/>? Bug: https://bugs.openjdk.java.net/browse/JDK-8170192 This patch is fully same as Daniel provided except a few lines of additional cleaning, thanks to Daniel for providing the patch! Thanks Frank
