Looks good Frank Best Lance > On Nov 23, 2016, at 9:29 PM, Frank Yuan <[email protected]> wrote: > > Hi Jon > > > > Thank you for your advice! > > > > Please check the update http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/ > , which contains jcommander.jar and removes the extra > blank lines following Christoph's suggestion. > > > > Frank > > > > From: Jonathan Gibbons [mailto:[email protected]] > Sent: Thursday, November 24, 2016 4:26 AM > Subject: Re: RFR JDK-8170192 [JAXP] [TESTBUG] > test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant > permissions > to jtreg, javatest, and testng jars > > > > Frank, > > More recent builds of testng.jar, such as the builds available on Maven, > have separated out the jcommander component so that two > jar files are required: testng.jar and jcommander.jar. > > You should consider taking jcommander.jar into account. This will be more > important/noticeable to folk outside Oracle who build > their own copy of jtreg to use. > > -- Jon > > On 11/22/2016 08:41 PM, Frank Yuan wrote: > > Hi All > > > > Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/ > <http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/> ? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8170192 > > > > This patch is fully same as Daniel provided except a few lines of additional > cleaning, thanks to Daniel for providing the patch! > > > > Thanks > > Frank > > > > >
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
