Hi Masayoshi, I'm not a reviewer, but there's something in JapaneseEra.java.cdiff.html <http://cr.openjdk.java.net/~okutsu/9/8054214/webrev.00/src/java.base/share/classes/java/time/chrono/JapaneseEra.java.cdiff.html> which isn't terribly clear to me, so I wonder if you could clarify it for me.
In the method `getDisplayName(TextStyle style, Locale locale)`, it's not clear to me why the call to `Objects.requireNonNull(locale, "locale");` is within the if-statement rather than on the first line. Is this because `Era.super::getDisplayName` already has a null check of its own? Kind regards, Jonathan On 8 December 2016 at 08:55, Masayoshi Okutsu <masayoshi.oku...@oracle.com> wrote: > Hi, > > Please review the fix for JDK-8054214. It was necessary to override > Era::getDisplayName to get era names from the specified property. This one > fixes getAbbreviation() as well. > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8054214 > > Webrev: > http://cr.openjdk.java.net/~okutsu/9/8054214/webrev.00/ > > Thanks, > Masayoshi > >