Okutsu-san,

In JapaneseEra::getDisplayName, Should there be Objects.requireNonNull() check for "style"? The current impl seems to return abbreviated era if null is passed as "style".

Naoto

On 12/8/16 12:55 AM, Masayoshi Okutsu wrote:
Hi,

Please review the fix for JDK-8054214. It was necessary to override
Era::getDisplayName to get era names from the specified property. This
one fixes getAbbreviation() as well.

Issue:
https://bugs.openjdk.java.net/browse/JDK-8054214

Webrev:
http://cr.openjdk.java.net/~okutsu/9/8054214/webrev.00/

Thanks,
Masayoshi

Reply via email to