On 12/01/17 21:20, Naoto Sato wrote:
Realized moduleRef & callerRef would never be null with this new
version. Thus modified the patch as:
http://cr.openjdk.java.net/~naoto/8171139/webrev.03/
Hi Naoto,
619 this(src.getName(), src.getLocale(), src.getModule(),
src.getCallerModule());
this is going to throw NPE if either module is null.
I wonder if there is a risk that the modules might get
garbage collected between the time at which 'src' was obtained
and the time at which src.get[Caller]Module() is called.
If there's such a risk then maybe Reference::reachabilityFence
could be used at strategic places to prevent this?
Also the copy constructor will recompute the hash - (through the
this(...) constructor) and I wonder whether that's intended.
best regards,
-- daniel
Naoto
On 1/12/17 11:16 AM, Naoto Sato wrote:
Thank you, Mandy and Daniel for your comments. I incorporated your
suggestions and updated the fix as follows:
http://cr.openjdk.java.net/~naoto/8171139/webrev.02/
http://cr.openjdk.java.net/~naoto/8171140/webrev.00/
Please review.
Naoto
On 1/11/17 5:45 PM, Naoto Sato wrote:
Decided to include the fix to 8171140 [1] as well, as they are closely
related. Here is the updated webrev.
http://cr.openjdk.java.net/~naoto/8171139.8171140/webrev.01/
Additional changes to the version 00 are to mainly remove
clearCache(Module) method, as clearCache() is chiefly used in
combination with ResourceBundle.Control, which is not supported in named
modules. Still named modules can issue clearCache() with no argument
which will result in the same effect. Also, other clearCache() overloads
have clearer method descriptions.
CCC for 8171140 will be filed accordingly.
Naoto
--
[1]: https://bugs.openjdk.java.net/browse/JDK-8171140
On 1/10/17 4:10 PM, Naoto Sato wrote:
Hello,
Please review the changes to the subject issue:
https://bugs.openjdk.java.net/browse/JDK-8171139
The changes are located at:
http://cr.openjdk.java.net/~naoto/8171139/webrev.00/
The changeset is the same as the one in the mail thread [1]
contributed by Peter Levart, plus additional clearCache() test cases.
Naoto
[1]
http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-January/045790.html
<http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-January/045790.html>
