Looks good Joe. I wonder about this though (which may be an issue for another time):
102 [25] Eq ::= S? '=' S? Do we support space (new line?) before and after the '=' sign? best regards, -- daniel On 14/02/17 02:27, huizhe wang wrote:
A quick fix for the error parsing xml declaration. This is one of the three outstanding issues in the xml area that must be addressed for the coming development deadline. JBS: https://bugs.openjdk.java.net/browse/JDK-8169450 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ Checking whether a space follows "<?xml" was sufficient for DOM/SAX for which the base parser was originally created since the xml declaration was normalized during version detection. StAX, sharing the base parser after it was added to the JDK, however, does not use the same version detection/normalization process and would incorrectly parse the declaration if there are other whitespaces. Thanks, Joe
